feat: render markdown in calendar event descriptions #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment of preview was successful: https://xHain-hackspace-xhain-website-pr-76.surge.sh |
pantierra
reviewed
Apr 18, 2024
layouts/calendar/list.html
Outdated
| @@ -82,4 +82,8 @@ <h1 id="article-title">{{ .Title }}</h1> | |||
| aria-modal="true" | |||
| ></div> | |||
| </main> | |||
|
|
|||
| {{/* render the event descriptions as markdown */}} | |||
| <script src="https://cdn.jsdelivr.net/npm/marked/marked.min.js"></script> | |||
There was a problem hiding this comment.
Let's not load libraries from external sources. Include it in the codebase, please.
There was a problem hiding this comment.
I did it this way since we don't currently use any package managers. If that's the preferred option I'll refactor.
jdwillemse
force-pushed
the
feat/calendar-markdown
branch
from
842cf07
to
90b46f0
Compare
jdwillemse
commented
May 14, 2024
|
|
||
| * just edit new post in the "content"-folder | ||
| - just edit new post in the "content"-folder | ||
|
|
||
| ## Calendar | ||
|
|
There was a problem hiding this comment.
The formatting changes were made by prettier to bring the file in line with best practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #66 and also adds the option to format calendar descriptions better